Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close old AudioContexts #29

Merged
merged 1 commit into from Jun 22, 2016
Merged

Conversation

Costava
Copy link
Contributor

@Costava Costava commented Jun 22, 2016

"The close() method of the AudioContext Interface closes the audio context, releasing any system audio resources that it uses [...] it will forcibly release any system audio resources that might prevent additional AudioContexts from being created and used"

from https://developer.mozilla.org/en-US/docs/Web/API/AudioContext/close

The destroy method of the Conductor class instantiates new AudioContexts but does not close the old ones. Firefox either closes the AudioContexts for you, or otherwise deals with the situation, but Chrome will give an error if enough AudioContexts are instantiated without being closed:

band.js:191 Uncaught NotSupportedError: Failed to construct 'AudioContext': The number of hardware contexts provided (6) is greater than or equal to the maximum bound (6).

This error is reproducible by calling the destroy method enough (~5 times. destroy is called when loading from JSON).

Google Chrome Version 51.0.2704.103

@meenie
Copy link
Owner

meenie commented Jun 22, 2016

Awesome, thanks!

@meenie meenie merged commit 8244081 into meenie:master Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants